RE: [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: convertGFP_KERNEL to GFP_ATOMIC

From: Bing Zhao
Date: Mon Jan 09 2012 - 13:51:46 EST


Hi Julia,

Thanks for the patch.

> Subject: [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: convert GFP_KERNEL to GFP_ATOMIC
>
> From: Julia Lawall <julia.lawall@xxxxxxx>
>
> The function is called with locks held and thus should not use GFP_KERNEL.
>
> The semantic patch that makes this report is available
> in scripts/coccinelle/locks/call_kern.cocci.
>
> More information about semantic patching is available at
> http://coccinelle.lip6.fr/
>
> Signed-off-by: Julia Lawall <julia.lawall@xxxxxxx>

Acked-by: Bing Zhao <bzhao@xxxxxxxxxxx>

Regards,
Bing

>
> ---
> drivers/net/wireless/mwifiex/scan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mwifiex/scan.c b/drivers/net/wireless/mwifiex/scan.c
> index 6396d33..98f1ca9 100644
> --- a/drivers/net/wireless/mwifiex/scan.c
> +++ b/drivers/net/wireless/mwifiex/scan.c
> @@ -2001,7 +2001,7 @@ mwifiex_save_curr_bcn(struct mwifiex_private *priv)
>
> kfree(priv->curr_bcn_buf);
> priv->curr_bcn_buf = kmalloc(curr_bss->beacon_buf_size,
> - GFP_KERNEL);
> + GFP_ATOMIC);
> if (!priv->curr_bcn_buf) {
> dev_err(priv->adapter->dev,
> "failed to alloc curr_bcn_buf\n");

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/