Re: drivers/regulator/core.c: Fixes mapping insideregulator_mode_to_status() and makes it returning -EINVAL oninvalid input.

[Mark Brown]

On Mon, Jan 09, 2012 at 07:20:50PM +0000, dd diasemi wrote:
> On Mon, Jan 9, 2012 at 4:14 PM, Mark Brown

> >>       default:
> >> -             return 0;
> >> +             return -EINVAL;

> > This behaviour is deliberate.

> For this moment, the only usage is in one file in
> wm831x_aldo_get_status() and wm831x_gp_ldo_get_status():
> 	ret = wm831x_aldo_get_mode(rdev);
> 	if (ret < 0)
> 		return ret;
> 	else
> 		return regulator_mode_to_status(ret);

> The usage mistreats the signed value 'ret' as wm831x_aldo_get_mode()
> always returns 0 on communication error. It effects in response as if
> the regulator was off.

> If that behaviour is deliberate, I would suggest to make it explicit:
>  	default:
> -		return 0;
> +		return REGULATOR_STATUS_OFF;

That's not the deliberate behaviour, the deliberate behaviour is to
return no mode if we didn't find one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/