Re: [27/27] clockevents: Set noop handler inclockevents_exchange_device()

[Thomas Gleixner]

On Thu, 29 Dec 2011, Linus Torvalds wrote:

> On Thu, Dec 29, 2011 at 4:09 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> >
> > This is basically the reverse of 7c1e768974 (clockevents: prevent
> > clockevent event_handler ending up handler_noop, 2008-09-03).  The
> > rationale for the latter still applies.
> 
> Hmm. You seem to be right. Instead of applying this to stable, it
> looks like we should revert it from mainline.
> 
> >                  People have been reporting
> > the analagous patch to this one causing hangs on resume in 3.1.y and
> > 3.2 release candidates:
> >
> >  - http://thread.gmane.org/gmane.linux.kernel/1233033
> >  - http://thread.gmane.org/gmane.linux.kernel/1233389
> >  - http://thread.gmane.org/gmane.linux.kernel/1233159
> >  - http://thread.gmane.org/gmane.linux.kernel/1227868/focus=1230877
> >
> > So please consider reverting it for now.
> 
> Thomas? It does seem to be broken and there do seem to be regression
> reports about it.
> 
> Should I revert it, or do you have alternative fixes?

Hmm. I have no idea what broke. Will have a look.

Thanks,

	tglx