Re: [PATCH 3/3] Code clean up for percpu_xxx() functions

[tj@xxxxxxxxxx]

On Wed, Jan 11, 2012 at 05:08:41PM +0800, Alex,Shi wrote:
> On Mon, 2011-11-21 at 17:06 -0700, tj@xxxxxxxxxx wrote:
> > (cc'ing hpa and quoting whole body)
> > > 
> > > Signed-off-by: Alex Shi <alex.shi@xxxxxxxxx>
> > > Acked-by: Christoph Lameter <cl@xxxxxxxxxx>
> > 
> >  Acked-by: Tejun Heo <tj@xxxxxxxxxx>
> > 
> > hpa, I suppose this should go through x86?  The original patch can be
> > accessed at
> > 
> >   http://article.gmane.org/gmane.linux.kernel/1218055/raw
> 
> Rend for 3.2 kernel, no any change needed to apply on latest Linus'
> tree. :) 
> 
> Actually, this clean up has no performance or security impact for
> kernel. On the contrary, removing some potential redundant preempt
> disable will bring a slight performance benefit to kernel. 
> 
> This 3rd patch depends on previous 2 patches, the 2nd one kvm code clean
> up was submitted for 3.3 kernel. but the 2st one net code clean up is
> waiting for David's comments.

Alex, can you please collect all patches into a single patchset?
Please split it such that, usage changes are per-system so that they
can be routed through respective subsystems (x86 or net) and updates
to percpu proper which can be applied after other changes have been
applied.  It would probably be best to route these patches separately
rather than all through percpu as it touches a lot of different places
and is likely to cause conflicts.  I *think* the best way would be,

* Submit per-subsystem patches and get them merged to subsystem trees.

* (Optional) Apply a patch to mark unused interface deprecated in
  percpu tree, so that new usages in linux-next can be detected.

* Towards the end of the next merge window, merge a patch to actually
  kill the old interface.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/