Re: [PATCH v2] input/mc13783-ts: add pdata to set conversion delay

[Dmitry Torokhov]

On Wed, Jan 11, 2012 at 11:49:23AM +0100, Michael Thalmeier wrote:
>  
> +struct mc13xxx_ts_platform_data {
> +	/* Delay between Touchscreen polarization and ADC Conversion.
> +	 * Given in clock ticks of a 32 kHz clock which gives a granularity of
> +	 * about 30.5ms */
> +	char ato;
> +
> +#define MC13783_TS_ATO_FIRST 0
> +#define MC13783_TS_ATO_EACH  1
> +	/* Use the ATO delay only for the first conversion or for each one */
> +	char atox;
> +};


'char' for these 2 looks wrong, 2 u8, u8 and bool or int and bool would
be better.

Otherwise am OK with input bits.

Acked-by: Dmitry Torokhov <dtor@xxxxxxx>

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/