Re: [RFC PATCH] xfs: show uuid when mount fails due to duplicate uuid

[Christoph Hellwig]

On Thu, Jan 12, 2012 at 11:47:20AM +0900, Mitsuo Hayasaka wrote:
> When a system tries to mount a filesystem (FS) using UUID, the xfs
> returns -EINVAL and shows a message if a FS with the same UUID has
> been already mounted. It is useful to output the duplicate UUID
> with it.

Looks good to me,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

> -	xfs_warn(mp, "Filesystem has duplicate UUID - can't mount");
> +	xfs_warn(mp,
> +		"Filesystem has duplicate UUID - can't mount: uuid = %pU",
> +		uuid);

Maybe we could write this a bit nicer as:

	xfs_warn(mp, "Filesystem has duplicate UUID %p - can't mount", uuid);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/