Re: [PATCH 11/12] blkcg: kill blkio_policy_node

[Vivek Goyal]

On Thu, Jan 19, 2012 at 02:03:06PM -0800, Tejun Heo wrote:

[..]
> > Why do we check for blkg->conf.weight=0 here. Even if a group already has
> > weight and if user has changed the cgroup weight later, that update should
> > be propogated to all the groups on all the queues.
> 
> Maybe I misread the code but if explicit per-device config exists,
> cgroup-wide writes are ignored, no?  The original code searches for
> matching pn and if it exists, continues without updating.
> 
> > Where do we assign default cgroup weight to a blkg upon creation? May be at
> > group create time, we just need to copy blkcg->weight to blkg.conf.weight.
> 
> We don't.  blk->conf.weight is set only on explicit per-device
> configuration.  It's gonna be removed eventually after config
> definition and handling are moved into policies.

Ok. So blkg->conf.weight is set only for per device weights. For groups
using cgroup weight, I see that cfq inherits it during group creation.
Any updates to cgroup weight are sent only if per device weight is not
set. Previously we used to do this check by looking for policy node and
you are checking for blkg.weight. That clarifies it. Thank.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/