Re: [PATCH 1/6] staging:android_pmem.h: Fixes the space and otherformating issues pointed out by checkpatch.pl

From: Dan Carpenter
Date: Fri Jan 20 2012 - 08:49:54 EST


On Fri, Jan 20, 2012 at 05:29:04AM -0800, Joe Perches wrote:
> > #define PMEM_IS_FREE(id, index) (!(pmem[id].bitmap[index].allocated))
> >
> > That has two pairs of unneeded paranthesis and we run the risk of
> > reprogramming the kernel in lisp, by mistake.
>
> I think the outer parens are necessary.
> Imagine PMEM_IS_FREE(foo, bar).another_dereference

That's not going to happen in real life.

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature