Re: [PATCH 6/6] Staging: android: Add parenthesis to macros withcomplex values in pmem.c

From: Dan Carpenter
Date: Sat Jan 21 2012 - 03:23:15 EST


On Sat, Jan 21, 2012 at 04:23:32AM +0000, Kashyap Gada wrote:
> -#define PMEM_IS_FREE(id, index) !(pmem[id].bitmap[index].allocated)
> -#define PMEM_ORDER(id, index) pmem[id].bitmap[index].order
> +#define PMEM_IS_FREE(id, index) (!(pmem[id].bitmap[index].allocated))
> +#define PMEM_ORDER(id, index) (pmem[id].bitmap[index].order)

These are not needed. We're modifying checkpatch.pl to not complain
about these, but it hasn't been merged yet.

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature