Re: [PATCH 08/17] blkcg: shoot down blkio_groups on elevator switch

From: Tejun Heo
Date: Mon Jan 23 2012 - 11:16:23 EST


On Mon, Jan 23, 2012 at 11:10:42AM -0500, Vivek Goyal wrote:
> This does not work well in hierachical management/scenario. Think that
> a user gets an upper limit of 10MB/s on a device and now user can manage
> its own children groups and divide allocated 10MB/s in children the way
> he wants.
>
> Now if root does the elevator switch, and saves all the rules (including
> user's rules) and then restores back, these can very well race with
> user's scripts of changing rules. If user changed a cgroup device rule
> during elevator switch and after elevator switch root restored back
> old rules, user's new rule will be lost leading to confusion.

It simply doesn't matter. Just declare elvswitch and policy change
reset blkcg configurations. If some people are crazy enough to switch
elevators regularly with full system running and parallel
configuration going on, let them deal with synchronizing their
scripts.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/