Re: [PATCH 1/7] PCI: Make sriov work with hotplug remove

[Yinghai Lu]

On Mon, Jan 23, 2012 at 11:34 AM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>  (b) if that isn't an option, and the virtual devices make a mess, at
> least don't make the code uglier, just do something like:
>
>    while (!list_empty(&bus->devices)) {
>        struct pci_dev *dev = list_first_entry(struct pci_dev, bus_list);
>
>        pci_stop_bus_device(dev);
>    }
>
> which at least isn't butt ugly. Add a large comment about how
> pci_stop_bus_device() can remove multiple devices due to the virtual
> devices having been done badly.

yes, this one should work and less confusing.

>
> Who is in charge of the whole 'is_virtfn' mess? How realistic is it to
> fix that crud?

Not sure.  it seems the guy Yu Zhao (?) already left intel several years ago.

It seems  ./scripts/get_maintainer.pl for pci patches now only return Jesse.

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/