Re: [PATCH] xfs: remove unecessary AIL push wakeups

[Christoph Hellwig]

On Fri, Jan 13, 2012 at 01:30:28AM +0800, JiSheng Zhang wrote:
> 
> In commit 0030807c66("xfs: revert to using a kthread for AIL pushing"),
> AIL pushing is revert back to use a kthread. But unfortunately, it
> introduced a regression: there are unnecessary AIL push wakeups during
> idle, ~20 wakeups/s. This change remove the wakeups by reverting a bit
> more: set "tout" value as zero during idle.
> 
> Signed-off-by: JiSheng Zhang <jszhang3@xxxxxxxxxxxxxxxx>

Looks fine, although I'm a bit worried that I don't have the setup to
reproduce the issue that the patch addressed any more and we might
regress here.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/