Re: [PATCH V2] regulator: tps65910: Sleep control through externalinputs

From: Mark Brown
Date: Wed Jan 25 2012 - 07:50:21 EST


On Wed, Jan 25, 2012 at 06:17:43PM +0530, Laxman Dewangan wrote:
> On Wednesday 25 January 2012 06:12 PM, Mark Brown wrote:

> >This really isn't what the set_mode() API is for - especially the fact
> >that it supports turning the regulator off which really isn't what
> >set_mode() is supposed to do. A generic driver using this API isn't
> >going to play too well.

> Then what should be the method? Is it through the macro similar to
> patch V1 where LOW_POWER mode option come from platform data? The
> idea is to set the regulator in OFF or low power mode based on
> external control.

Like I said we've got the various suspend callbacks for setting the
behaviour in suspend mode.

Attachment: signature.asc
Description: Digital signature