Re: [patch v4, kernel version 3.2.1] Source mode for macvlaninterface

From: David Miller
Date: Wed Jan 25 2012 - 21:39:07 EST


From: Stefan Gula <steweg@xxxxxxx>
Date: Wed, 25 Jan 2012 09:48:54 +0100 (CET)

> + if (vlan->mode == MACVLAN_MODE_SOURCE &&
> + vlan->mode != nla_get_u32(data[IFLA_MACVLAN_MODE]))
...
> + if (data && data[IFLA_MACVLAN_MACADDR_MODE] &&
> + data[IFLA_MACVLAN_MACADDR]) {
...
> + return macvlan_hash_add_sources(vlan,
> + nla_data(data[IFLA_MACVLAN_MACADDR]));
...
> + hlist_for_each_entry_rcu(list, n,
> + &vlan->port->vlan_source_hash[i], hlist) {
...
> + hlist_for_each_entry_rcu(list, n,
> + &vlan->port->vlan_source_hash[i], hlist) {

Line things up on subsequent lines to the column right after the
openning parenthesis on the previous line.

If things are indented too deeply, you need to write helper functions.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/