Re: [GIT PULL] MCE recovery changes

[Tony Luck]

On Thu, Jan 26, 2012 at 2:46 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
> It worked perfectly.

Hurrah!

> Pulled, thanks!

Thank you.

> One thing i noticed was the magic constant 0x134:
>
> +               SER, MASK(MCI_STATUS_OVER|MCI_UC_SAR|MCI_ADDR|MCACOD, MCI_UC_SAR|MCI_ADDR|0x0134),
>
> don't we want that defined a bit more clearly?

Stylistically it is compatible with the existing:
MASK(MCI_STATUS_OVER|MCI_UC_SAR|0xfff0, MCI_UC_S|0x00c0)
and
MASK(MCI_STATUS_OVER|MCI_UC_SAR|MCACOD, MCI_UC_S|0x017a)

... but that's just a sign that they need some love too :-)

I'll see what I can do - but meaningful names will clearly be longer than
the hex constants that they replace - and I'm already pushing line length
limits here, so it will need more than a trivial restructure.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/