Re: [patch v2, kernel 3.2.1] RTNETLINK adjusting values ofmin_ifinfo_dump_size

[David Miller]

From: Stefan Gula <steweg@xxxxxxx>
Date: Thu, 26 Jan 2012 22:01:06 +0100 (CET)

> From: Stefan Gula <steweg@xxxxxxxxx>
> 
> Setting link parameters on a netdevice changes the value
> of if_nlmsg_size(), therefore it is necessary to recalculate
> min_ifinfo_dump_size.
> 
> Signed-off-by: Stefan Gula <steweg@xxxxxxxxx>

Applied, but:

> +	min_ifinfo_dump_size = max_t(u16, if_nlmsg_size(dev),
> +					min_ifinfo_dump_size);
> +

The second line is not properly indented, the first non-space
character should line up with the first column after the
openning parenthesis on the previous line.

I fixed this up, but really this was a lot of tooth pulling to
get you to post this patch correctly.  You cannot consume this
much maintainer and reviewer resources in the future.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/