Re: [RFC c/r 2/4] [RFC] syscalls, x86: Add __NR_kcmp syscall v7

[H. Peter Anvin]

On 01/27/2012 12:34 PM, Glauber Costa wrote:
>>> +	case KCMP_SYSVSEM:
>>> +#ifdef CONFIG_SYSVIPC
>>> +		ret = kcmp_ptr((long)task1->sysvsem.undo_list,
>>> +			       (long)task2->sysvsem.undo_list,
>>> +			       KCMP_SYSVSEM);
>>> +#else
>>> +		ret = -EINVAL;
>>
>> ENOTSUP is better, I think. because of, EINVAL implicitly mean _caller_ is wrong.
>> but in this case, it is not bad. only the kernel doesn't have enough feature.
>>
> 
> Isn't it usually the case for ENOSYS, then ?
> 

ENOSYS means "no such system call".  That would apply if the kcmp system
call itself did not exist.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/