Re: [PATCH v5 1/3] seccomp: kill the seccomp_t typedef

From: Greg KH
Date: Fri Jan 27 2012 - 18:42:32 EST


On Fri, Jan 27, 2012 at 05:24:39PM -0600, Will Drewry wrote:
> Replaces the seccomp_t typedef with seccomp_struct to match modern
> kernel style.
>
> Signed-off-by: Will Drewry <wad@xxxxxxxxxxxx>
> ---
> include/linux/sched.h | 2 +-
> include/linux/seccomp.h | 10 ++++++----
> 2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index 4032ec1..288b5cb 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -1418,7 +1418,7 @@ struct task_struct {
> uid_t loginuid;
> unsigned int sessionid;
> #endif
> - seccomp_t seccomp;
> + struct seccomp_struct seccomp;

Isn't 'struct seccomp_struct' a bit redundant?

How about a simple 'struct seccomp' instead?

That is, if this is even needed...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/