Re: [alsa-devel] [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missingiounmap

[Julia Lawall]

On Sat, 28 Jan 2012, Wolfram Sang wrote:

> > > You can skip checking 'iores', too. I also did that in the example, but
> > > a lot of people seem to miss it.
> >
> > I can try to do that, but it seems a little bit unintuitive.
> > Perhaps it would be easier for people to remember to put in error
> > handling code when they need it if they always have to do it?  If I
> > remove it, there will be one call that has no test and then another
> > call a few lines later that does.
>
> I see your point. I would still like to get rid of the duplicated code
> (then it can't be forgotten as well). Maybe I should have named the
> function something alike devm_check_and_request_and_ioremap()? Then I
> could have also introduced a similar function for requesting irq. Will
> think about this a bit more. Thanks for updating your patch!

Despite believing in my point, error handling code is where people make a 
lot of mistakes.  Getting rid of it seems always to be a good idea.  Maybe 
such checks could be moved into more uses of the result of 
platform_get_resource.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/