Re: [PATCH] x86, reboot: reduce to a single DMI table for rebootquirks
From: Ingo Molnar
Date: Mon Jan 30 2012 - 04:55:54 EST
I've applied your first two patches, thanks Michael!
Regarding this patch, it does not apply cleanly to the latest
x86 tree:
2 out of 5 hunks FAILED -- rejects in file arch/x86/kernel/reboot.c
which you can pick up from:
git pull git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git master
Also, a style nit, these comments:
> + /* Write zero to CMOS register number 0x0f, which the BIOS POST
> + routine will recognize as telling it to do a proper reboot. (Well
> + that's what this book in front of me says -- it may only apply to
> + the Phoenix BIOS though, it's not clear). At the same time,
> + disable NMIs by setting the top bit in the CMOS address register,
> + as we're about to do peculiar things to the CPU. I'm not sure if
> + `outb_p' is needed instead of just `outb'. Use it to be on the
> + safe side. (Yes, CMOS_WRITE does outb_p's. - Paul G.)
> + */
and the other similar comments that you move should be coverted
to the customary (multi-line) comment style:
/*
* Comment .....
* ...... goes here.
*/
specified in Documentation/CodingStyle.
I realize that you only move code here - but it's worth cleaning
it up a bit when touching it.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/