Re: [RFC 1/2] regmap: if format_write is used, declare all registersas "unreadable"

From: Mark Brown
Date: Mon Jan 30 2012 - 11:25:29 EST


On Mon, Jan 30, 2012 at 03:08:16PM +0100, Wolfram Sang wrote:
> Using .format_write means, we have a custom function to write to the
> chip, but not to read back. Also, mark registers as "not precious" and
> "not volatile" which is implicit because we cannot read them. Make those
> functions use 'regmap_readable' to reuse the checks done there.

Applied, thanks.

There are actually some chips that manage to implement read support in
conjunction with odd register formats but none of these are using regmap
right now and it's not altogether clear to me that it's a good idea for
them to do so as they tend to be doing entertaining things that would at
least need some framework additions. Anyone doing that work can worry
about it then.

Attachment: signature.asc
Description: Digital signature