Re: [PATCH 1/3] percpu: use ZERO_SIZE_PTR / ZERO_OR_NULL_PTR

[Christoph Lameter]

On Mon, 30 Jan 2012, Tejun Heo wrote:

> On Mon, Jan 30, 2012 at 11:22:14AM -0600, Christoph Lameter wrote:
> > On Mon, 30 Jan 2012, Tejun Heo wrote:
> >
> > > Percpu pointers are in a different address space and using
> > > ZERO_SIZE_PTR directly will trigger sparse address space warning.
> > > Also, I'm not entirely sure whether 16 is guaranteed to be unused in
> > > percpu address space (maybe it is but I don't think we have anything
> > > enforcing that).
> >
> > We are already checking for NULL on free. So there is a presumption that
> > these numbers are unused.
>
> Yes, we probably don't use 16 as valid dynamic address because static
> area would be larger than that.  It's just fuzzier than NULL.  And, as
> I wrote in another reply, ZERO_SIZE_PTR simply doesn't contribute
> anything.  Maybe we can update the allocator to always not use the
> lowest 4k for either static or dynamic and add debug code to
> translation macros to check for percpu addresses < 4k, but without
> such changes ZERO_SIZE_PTR simply doesn't do anything.

We have two possibilities now:

1. We say that the value returned from the per cpu allocator is an opaque
value.

	This means that we have to remove the NULL check from the free
	function. And audit the kernel code for all occurrences where
	a per cpu pointer value of NULL is assumed to mean that no per
	cpu allocation has occurred.

2. We say that there are special values for the per cpu pointers (NULL,
	ZERO_SIZE_PTR)

	Then we would have to guarantee that the per cpu allocator never
	returns those values.

	Plus then the ZERO_SIZE_PTR patch will be fine.

	The danger exist of these values being passed as
	parameters to functions that do not support them (per_cpu_ptr
	etc). Those would need VM_BUG_ONs or some other checks to detect
	potential problems.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/