Re: [PATCH 4/5] TTY: pty, remove superfluous ptm test

[Alan Cox]

On Mon, 30 Jan 2012 21:14:31 +0100
Jiri Slaby <jslaby@xxxxxxx> wrote:

> The code looks like:
> if (tty->driver->subtype == PTY_TYPE_MASTER) {
>   ...
>   if (tty->driver == ptm_driver)
> 
> But the second if is superfluous because only the ptm_driver is of
> PTY_TYPE_MASTER subtype.
> 
> Also we can remove the #if now because devpts_pty_kill is defined as
> an empty function for non-CONFIG_UNIX98_PTYS configs.
> 
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>

Acked-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/