Re: [PATCH] selftests: Make run_tests executable

From: Andrew Morton
Date: Mon Jan 30 2012 - 18:51:38 EST


On Mon, 30 Jan 2012 18:04:29 +0100
Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:

> Make the main script that launches the tests to
> become executable. Otherwise people need to launch
> it as an argument to a new bash instance.
>

That's a feature ;)

The x bit can easily get lost on kernel scripts. For example, if
someone upgrades their kernel with patch(1) and the patch adds or
renames the script, the x bit gets lost.

If we were to set the x bit for the subset of people who get their
scripts direct from a git repository then those people might write and
distribute tools which fail when used by people who have lost their x
bit. I've seen this happen at least once before.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/