Re: [PATCH v2] add LED driver for PCA9663 I2C chip

[Andrew Morton]

On Mon, 30 Jan 2012 16:28:49 -0800
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> > +exit:
> > +	while (i--) {
> > +		led_classdev_unregister(&pca9633[i].led_cdev);
> > +		cancel_work_sync(&pca9633[i].work);
> > +	}
> 
> This (untested!) loop has an off-by-one error. 

Well, it's partly wrong.  It's wrong for the cancel_work_sync() but not
for the led_classdev_unregister().  The cancel_work_sync() can just be
removed: we haven't scheduled any works yet.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/