Re: [PATCH] rtlwifi/rtl8192c: in _rtl92c_phy_calculate_bit_shiftremove comparing bitmask against 1

[Joe Perches]

On Tue, 2012-01-31 at 02:11 -0500, Devendra.Naga wrote:
> From: "Devendra.Naga" <devendra.aaru@xxxxxxxxx>
[]
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
[]
> @@ -177,7 +177,7 @@ u32 _rtl92c_phy_calculate_bit_shift(u32 bitmask)
>  	u32 i;
>  
>  	for (i = 0; i <= 31; i++) {
> -		if (((bitmask >> i) & 0x1) == 1)
> +		if ((bitmask >> i) & 0x1)
>  			break;
>  	}
>  	return i;

Perhaps this is simpler and faster:

{
	u32 rtn = (u32)ffs((int)bitmask);
	if (rtn)
		return rtn - 1;
	return 32;
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/