Re: [PATCH] speed up /proc/pid/stat, statm

[Andrew Morton]

On Tue, 31 Jan 2012 17:14:43 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:

> +int seq_put_decimal_ll(struct seq_file *m, char delimiter,
> +			long long num)
> +{
> +	if (num < 0) {
> +		if (m->count + 3 >= m->size) {
> +			m->count = m->size;

Why is m->count udpated even thought we didn't write any data? 
seq_put_decimal_ull() does it too.

> +			return -1;
> +		}
> +		if (delimiter)
> +			m->buf[m->count++] = delimiter;
> +		num = -num;
> +		delimiter = '-';
> +	}
> +	return seq_put_decimal_ull(m, delimiter, num);
> +
> +}
> +EXPORT_SYMBOL(seq_put_decimal_ll);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/