Re: [PATCH] move vm tools from Documentation/vm/ to tools/

[Dave Young]

On 02/01/2012 02:45 PM, Cong Wang wrote:

> On 02/01/2012 02:34 PM, Dave Young wrote:
>> tools/ is the better place for vm tools which are used by many people.
>> Moving them to tools also make them open to more users instead of hide in
>> Documentation folder.
> 
> Well, hugepage-mmap, hugepage-shm, and map_hugetlb are examples, not
> really tools. So, only page-types is probably a tool, but I leave this
> to Fengguang to decide.


looks reasonable

> 
>>
>> Also fixed several coding style problem.
> 
> Make it another patch for people to review. :)


Will do

> 
> [...]
>> diff --git a/tools/vm/Makefile b/tools/vm/Makefile
>> new file mode 100644
>> index 0000000..b4f9fdd
>> --- /dev/null
>> +++ b/tools/vm/Makefile
>> @@ -0,0 +1,11 @@
>> +# Makefile for vm tools
>> +
>> +CC = $(CROSS_COMPILE)gcc
>> +CFLAGS = -Wall -Wextra
>> +
>> +all: page-types hugepage-mmap hugepage-shm map_hugetlb
>> +%: %.c
>> +    $(CC) $(CFLAGS) -o $@ $^
>> +
>> +clean:
>> +    $(RM) page-types hugepage-mmap hugepage-shm map_hugetlb
> 
> Is $(RM) defined?


It's a predefined variables of GNU makefile, It Imply rule of 'rm -f'

-- 
Thanks
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/