Re: [PATCH 1/4] mfd/ab8500: fix error path bug

[Linus Walleij]

On Wed, Feb 1, 2012 at 5:24 PM, Maxime Coquelin
<maxime.coquelin@xxxxxxxxxxxxxx> wrote:
> On 02/01/2012 05:09 PM, Linus WALLEIJ wrote:

>> --- a/drivers/mfd/ab8500-core.c
>> +++ b/drivers/mfd/ab8500-core.c
>> @@ -956,9 +956,10 @@ int __devinit ab8500_init(struct ab8500 *ab8500)
>>        return ret;
>>
>>  out_freeirq:
>> -       if (ab8500->irq_base) {
>> +       if (ab8500->irq_base)
>>                free_irq(ab8500->irq, ab8500);
>>  out_removeirq:
>> +       if (ab8500->irq_base)
>>                ab8500_irq_remove(ab8500);
>>        }
>
> Shouldn't the above brace to be removed?

Yes of course, thanks for spotting this! Fixed it in my patch queue.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/