Re: [PATCH v2 2/7] MFD: twl6040: Convert to i2c driver, and separateit from twl core

From: Mark Brown
Date: Tue Feb 07 2012 - 08:43:45 EST


On Tue, Feb 07, 2012 at 03:39:24PM +0200, Peter Ujfalusi wrote:

> In the codec driver I have one 'shadow' register which does not exist on
> the HW. I'm going to need to have access to that shadow register's bits
> in the future transparently.

Alternatively just rewrite the code for that to use a variable in the
driver private data.

> I was wondering if we could add support to regmap for such SW only
> registers. This would only make sens if the cache is enabled. We could
> have a callback let's say shadow_reg() in remap_config struct. If it is
> a shadow reg we never reach out for the HW and operate only on the cache.
> Is this something we can add to regmap?

That just sounds far too icky - I'm really not happy that people have
been doing that in ASoC TBH, it just makes everything more tricky than
it should be. It save a little bit of effort with the control but just
pushes that complexity elsewhere where you're not expecting it.

Attachment: signature.asc
Description: Digital signature