Re: [PATCH 1/2] smsc95xx: add module parameter to turn off NICstatus leds

[David Miller]

From: Peter Meerwald <pmeerw@xxxxxxxxxx>
Date: Wed,  8 Feb 2012 12:08:51 +0100

> From: Peter Meerwald <p.meerwald@xxxxxxxxxxxxxxxxxx>
> 
> add module parameter to allow to turn off NIC status leds (link, 
> speed, activity); blinking LEDs are annoying outside the server room :)
> 
> default behaviour is not changed, tested on beagleboard-xm
> 
> Signed-off-by: Peter Meerwald <p.meerwald@xxxxxxxxxxxxxxxxxx>

No.  Create a generic mechanism, perhaps via ethtool, for users to
configure something like this.

Otherwise the next driver that wants to provide this kind of knob
will add yet another module parameter with yet another name, and
this kind of ad-hoc set of interfaces absolutely sucks for users.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/