Re: [PATCH] selftests: Launch individual selftests from the mainMakefile

From: Andrew Morton
Date: Wed Feb 08 2012 - 18:20:21 EST


On Wed, 8 Feb 2012 04:40:59 +0100
Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:

> Drop the run_tests script and launch the selftests by calling
> "make run_tests" from the selftests top directory instead. This
> delegates to the Makefile on each selftest directory where it
> is decided how to launch the local test.
>
> This drops the need to add each selftest directory on the
> now removed "run_tests" top script.

Looks good.

I did

cd tools/testing/selftests
make run_tests

and it didn't work. This?



From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: selftests/Makefile: make `run_tests' depend on `all'

So a "make run_tests" will build the tests before trying to run them.

Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

tools/testing/selftests/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN tools/testing/selftests/Makefile~a tools/testing/selftests/Makefile
--- a/tools/testing/selftests/Makefile~a
+++ a/tools/testing/selftests/Makefile
@@ -5,7 +5,7 @@ all:
make -C $$TARGET; \
done;

-run_tests:
+run_tests: all
for TARGET in $(TARGETS); do \
make -C $$TARGET run_tests; \
done;
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/