Re: [PATCH v8 4/8] smp: add func to IPI cpus based on parameter func

From: Gilad Ben-Yossef
Date: Thu Feb 09 2012 - 04:53:41 EST


On Thu, Feb 9, 2012 at 10:13 AM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, 9 Feb 2012 10:08:16 +0200 Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> wrote:
>
>> BTW -  I used a macro since I imitated the rest of the code in smp.h
>> but is there any
>> reason not to use an inline macro here?
>
> If it can be implemented in C then sure, go for it - that's superior in
> numerous ways.
>

OK, I tried that and got into a maze of cyclic include files and
function definitions so
I guess I now know why the original code used macros. I guess I'll
leave it as such
for now.

Thanks,
Gilad


--
Gilad Ben-Yossef
Chief Coffee Drinker
gilad@xxxxxxxxxxxxx
Israel Cell: +972-52-8260388
US Cell: +1-973-8260388
http://benyossef.com

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/