[PATCH] perf: add sanity check on addr in symbol__inc_addr_samples()

From: Stephane Eranian
Date: Thu Feb 09 2012 - 05:30:23 EST



Check the value of addr against the bounds of the symbol.
This is needed given we compute an offset:
offset = addr - sym->start

And we don't want the offset to become negative.

Signed-off-by: Stephane Eranian <eranian@xxxxxxxxxx>

diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 011ed26..8248d80 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -64,7 +64,7 @@ int symbol__inc_addr_samples(struct symbol *sym, struct map *map,

pr_debug3("%s: addr=%#" PRIx64 "\n", __func__, map->unmap_ip(map, addr));

- if (addr >= sym->end)
+ if (addr >= sym->end || addr < sym->start)
return 0;

offset = addr - sym->start;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/