Re: [PATCH] ACPI: Fix logic for removing mappings in 'acpi_unmap'

[Bjorn Helgaas]

On Thu, Feb 9, 2012 at 8:36 AM, Myron Stowe <myron.stowe@xxxxxxxxxx> wrote:
> From: Myron Stowe <mstowe@xxxxxxxxxx>
>
> Make sure the removal of mappings uses the same logic that put the
> mappings in place.
>
> Signed-off-by: Myron Stowe <myron.stowe@xxxxxxxxxx>
> ---
>
>  drivers/acpi/osl.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 412a1e0..5aef087 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -347,7 +347,7 @@ static void acpi_unmap(acpi_physical_address pg_off, void __iomem *vaddr)
>        unsigned long pfn;
>
>        pfn = pg_off >> PAGE_SHIFT;
> -       if (page_is_ram(pfn))
> +       if (should_use_kmap(pfn))
>                kunmap(pfn_to_page(pfn));
>        else
>                iounmap(vaddr);
>

Whatever happened to the question of why we have arch-specific
ioremap() behavior?  It's good to make map/unmap symmetric, but it'd
be better to get rid of the ioremap/kmap hack.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/