Re: [PATCH RFC v2] slab: introduce kmalloc_array

From: Andrew Morton
Date: Thu Feb 09 2012 - 18:06:51 EST


On Thu, 9 Feb 2012 23:47:42 +0100 (CET)
Jesper Juhl <jj@xxxxxxxxxxxxx> wrote:

> > -static inline void *kcalloc(size_t n, size_t size, gfp_t flags)
> > +static inline void *kmalloc_array(size_t n, size_t size, gfp_t flags)
> > {
> > if (size != 0 && n > ULONG_MAX / size)
> > return NULL;
> > - return __kmalloc(n * size, flags | __GFP_ZERO);
> > + return __kmalloc(n * size, flags);
> > +}
> > +
> > +/**
> > + * kcalloc - allocate memory for an array. The memory is set to zero.
> > + * @n: number of elements.
> > + * @size: element size.
> > + * @flags: the type of memory to allocate (see kmalloc).
> > + */
> > +static inline void *kcalloc(size_t n, size_t size, gfp_t flags)
> > +{
> > + return kmalloc_array(n, size, flags | __GFP_ZERO);
> > }
> >
> > #if !defined(CONFIG_NUMA) && !defined(CONFIG_SLOB)
> >
>
> Does this want adding to Documentation/CodingStyle "Chapter 14: Allocating
> memory" ?

Spose so. We could possibly cook up a checkpatch rule too ;)

<gad, CodingStyle has 18 chapters and an appendix??>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/