Re: Staging: bcm: Don't leak 'pstAddIndication' inCmHost.c::StoreCmControlResponseMessage()

From: Greg KH
Date: Fri Feb 10 2012 - 13:02:29 EST


On Thu, Feb 09, 2012 at 11:33:25PM +0100, Jesper Juhl wrote:
> From: Jesper Juhl <jj@xxxxxxxxxxxxxx>
>
> We allocate memory for 'pstAddIndication' with kmalloc() in
> drivers/staging/bcm/CmHost.c::StoreCmControlResponseMessage() and then
> neglect to free it on a number of exit paths from that function.
>
> This could probably be resolved cleaner/nicer, but this file needs a
> serious overhaul in any case, so I opted for just fixing the problem
> as directly as I could and then we can clean it up generally
> later... This at least makes it stop bleeding..
>
> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxxx>

Odd, didn't I already apply this patch?

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/