Re: Staging: bcm: Don't leak 'pstAddIndication' inCmHost.c::StoreCmControlResponseMessage()

[Jesper Juhl]

On Fri, 10 Feb 2012, Greg KH wrote:

> On Thu, Feb 09, 2012 at 11:33:25PM +0100, Jesper Juhl wrote:
> > From: Jesper Juhl <jj@xxxxxxxxxxxxxx>
> > 
> > We allocate memory for 'pstAddIndication' with kmalloc() in
> > drivers/staging/bcm/CmHost.c::StoreCmControlResponseMessage() and then
> > neglect to free it on a number of exit paths from that function.
> > 
> > This could probably be resolved cleaner/nicer, but this file needs a
> > serious overhaul in any case, so I opted for just fixing the problem
> > as directly as I could and then we can clean it up generally
> > later... This at least makes it stop bleeding..
> > 
> > Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxxx>
> 
> Odd, didn't I already apply this patch?
> 
> confused,
> 

Well, you were the one who (in email message with Message-ID: 
<20120209175217.GA13959@xxxxxxxxx>) said that it no longer applied and 
asked for a resubmit against linux-next:

  "This patch no longer applies, care to redo it against the latest
  linux-next tree?"

So I just did what you asked :-)

Whether or not you have already applied it somewhere else I have no 
idea...

-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/