Re: [patch net-next] cxgb3: update firmware version

From: Divy Le Ray
Date: Mon Feb 13 2012 - 16:40:01 EST


On Monday, February 13, 2012 12:43:37 PM, David Woodhouse wrote:

On Mon, 2012-02-13 at 12:28 -0800, Divy Le Ray wrote:

This patch updates the firmware version cxgb3 is requesting to 7.12.0.


I'm confused. Your patch doesn't change anything in the driver, except
the firmware version. So why is it a "major" change?

Hi David,

cxgb3 embeds the firmware file name it will request at load time.
It uses the FW_VERSION_* defs to construct the firmware name FW_FNAME before calling request_firmware().
Hence the need to update the firmware minor version.

On the other hand, the driver version update is not a strict requirement here.
I would prefer keeping it though.

Cheers,
Divy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/