Re: [PATCH 2/9] ARM: at91/snapper9260: move gpio_to_irq out ofstructure initialization

From: Russell King - ARM Linux
Date: Tue Feb 14 2012 - 04:49:00 EST


On Tue, Feb 14, 2012 at 07:02:20AM +1100, Ryan Mallon wrote:
> On 14/02/12 01:43, Nicolas Ferre wrote:
>
> > gpio_to_irq() implementation will be moved from a macro to a
> > plain function: we cannot use it in a structure initialization
> > anymore.
>
> What was the reason for the change? It was originally a macro for
> exactly this reason.

gpio_to_irq() is supposed to work not only for built-in GPIOs, but also
GPIOs provided by other devices. Having it as a definition which only
works for the SoC GPIOs is broken.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/