Re: [PATCH block/for-linus 1/3] block: replace icq->changed with icq->flags

[Shaohua Li]

2012/2/15 Tejun Heo <tj@xxxxxxxxxx>:
> icq->changed was used for ICQ_*_CHANGED bits.  Rename it to flags and
> access it under ioc->lock instead of using atomic bitops.
> ioc_get_changed() is added so that the changed part can be fetched and
> cleared as before.
>
> icq->flags will be used to carry other flags.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> ---
> Jens, these three patches are to fix the swap heavy workload
> regression reported by Shaohua.
>
> Shaohua, I ended up changing the second patch, which shouldn't change
> anything but it would be great if you can verify this series once
> more.
yes, confirmed the patches fix the regression. Thanks for fixing it.
Tested-by: Shaohua Li <shaohua.li@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/