RE: [PATCH V2 RESEND] fsl-sata: I/O load balancing

From: Liu Qiang-B32616
Date: Wed Feb 15 2012 - 02:29:54 EST


> -----Original Message-----
> From: linux-ide-owner@xxxxxxxxxxxxxxx [mailto:linux-ide-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Li Yang
> Sent: Wednesday, February 15, 2012 3:22 PM
> To: Liu Qiang-B32616
> Cc: jgarzik@xxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx; linuxppc-
> dev@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH V2 RESEND] fsl-sata: I/O load balancing
>
> On Wed, Feb 15, 2012 at 1:49 PM, Qiang Liu <qiang.liu@xxxxxxxxxxxxx>
> wrote:
>
> Hi Liu Qiang,
>
> The patch is fine except for the title and comment. It's too vague to
> say I/O load balancing. You need explicit description like "add
> interrupt coalescing support" as title.
>
> > Reduce interrupt signals through reset Interrupt Coalescing Control Reg.
> > Provide dynamic method to adjust interrupt signals and timer ticks by
> sysfs.
> > It is a tradeoff for different applications.
>
> How about:
>
> Adds support for interrupt coalescing feature to reduce interrupt events.
> Provides mechanism of adjusting coalescing count and timeout tick by
> sysfs on runtime, so that tradeoff of latency and CPU load can be made
> depending on applications.
>
Ok, I will change the title and comments more specifically.

> - Leo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ide" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at
> http://vger.kernel.org/majordomo-info.html

¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶Ÿÿà -»+ƒùdš_