Re: [PATCH 8/12] arch/sparc: remove references to cpu_*_map.

From: Srivatsa S. Bhat
Date: Wed Feb 15 2012 - 04:22:55 EST


On 02/15/2012 10:28 AM, Rusty Russell wrote:

> From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
>
> This has been obsolescent for a while; time for the final push.
>
> Also get rid of obsolescent first_cpu().
>
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: sparclinux@xxxxxxxxxxxxxxx
> ---
> arch/sparc/kernel/leon_kernel.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/sparc/kernel/leon_kernel.c b/arch/sparc/kernel/leon_kernel.c
> --- a/arch/sparc/kernel/leon_kernel.c
> +++ b/arch/sparc/kernel/leon_kernel.c
> @@ -104,11 +104,11 @@ static int irq_choose_cpu(const struct c
> {
> cpumask_t mask;
>
> - cpus_and(mask, cpu_online_map, *affinity);
> - if (cpus_equal(mask, cpu_online_map) || cpus_empty(mask))
> + cpumask_and(&mask, cpu_online_mask, affinity);
> + if (cpumask_equal(&mask, cpu_online_mask) || cpus_empty(mask))


You could even change that cpus_empty() to cpumask_empty(&mask)...
Either way, it is fine..

Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@xxxxxxxxxxxxxxxxxx>

Regards,
Srivatsa S. Bhat

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/