Re: [PATCH v2] kbuild: Fix link to headers in 'make deb-pkg'

[Joerg Roedel]

On Tue, Feb 14, 2012 at 02:49:13AM +0000, Ben Hutchings wrote:
> On Mon, 2012-02-13 at 15:48 +0100, Joerg Roedel wrote:
> > The Link to the kernel header files in the debian packages
> > point to the original build directory. This is a bad choice
> > if the packages were installed on a different machine. Fix
> > this in by manually re-creating the link in the builddeb
> > script.
> > 
> > Cc: Michal Marek <mmarek@xxxxxxx>
> > Cc: maximilian attems <max@xxxxxxx>
> > Cc: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> > Cc: debian-kernel@xxxxxxxxxxxxxxxx
> > Cc: linux-kbuild@xxxxxxxxxxxxxxx
> > Signed-off-by: Joerg Roedel <joerg.roedel@xxxxxxx>
> 
> This looks good for !UML.
> 
> I wonder about the UML case though.  Did you test it?  In 3.3-rc3,
> 'make headers_install' is broken.  But if I suppress the header check,
> the resulting packages have links in the right places.

I havn't tested UML, I am not really familiar with using it. You are
probably right that for UML only the linux-image package is needed. I
can remove the UML check from this patch and post another one which
changes the script to only build linux-image for UML, how does that
sound?


	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/