Re: [PATCH UPDATED2 11/11] blkcg: unify blkg's for blkcg policies

From: Vivek Goyal
Date: Wed Feb 15 2012 - 12:02:34 EST


On Mon, Feb 13, 2012 at 05:33:47PM -0800, Tejun Heo wrote:

[..]
> Modified to update root blkgs on elvswitch too.
>
> Jens, there are a couple other changes but they're all trivial. I
> didn't want to repost both patchsets for those changes. The git
> branch has been updated. Ping me if you want the full series
> reposted.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git blkcg-unified-blkg
>
> I'd really like to get this into block/core and get some exposure in
> linux-next. There still are a lot of transitional stuff but I feel
> that there's now somewhat solid ground to build stuff atop. Vivek,
> what do you think?

Hi Tejun,

As this patch series is getting longer (already 2 sets are out there), I
think it is reasonable to get some testing going in linux-next. I can think
of atleast few more things which you might be planning to push before
3.4 merge window opens.

- Cleanup in-place policy data update logic.

- Do not kill all the groups upon one policy switch. Keep the group around
and just kill the policy data of associated policy.

- Get rid if locking complexity and rcu around group removal. Replace with
double lock dancing stuff.

- Fix the per cpu alloc stat alloc mess. This is anyway needed
irrespective of cleanup.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/