Re: [PATCH V1 2/3] Documentation: gpio: Add details of open-drainconfiguration

From: Laxman Dewangan
Date: Fri Feb 17 2012 - 05:33:14 EST


On Friday 17 February 2012 01:30 AM, Linus Walleij wrote:
On Thu, Feb 16, 2012 at 9:28 AM, Laxman Dewangan<ldewangan@xxxxxxxxxx> wrote:

Yes, I can add the open source also but like to be in incremental change.
Not together with open drain.
We can go with:
- open drain core driver support.
- open drain sysfs interface support
- open source core driver support
- open source sysfs interface.

I have already changes for the first 2 which we can review/apply,
Meanwhile I will work on open source support.

Does it look good?
Well as a patch concept it is OK but I have real bad feelings about
patch [2/4] and [4/4] adding sysfs.

What the GPIO subsystem really needs is to get rid of sysfs
interfaces, have them deprecated and replaced with a
per-gpiochip /dev/gpioN with ioctl()s or similar instead. The sysfs
interface is just ... it won't scale.

Wow, then I will not add 2/4 and 4/4.

Yours,
Linus Walleij

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/