Re: [PATCH 1/2] rmap: Staticize page_referenced_file andpage_referenced_anon

From: Peter Zijlstra
Date: Fri Feb 17 2012 - 13:08:10 EST


On Fri, 2012-02-17 at 10:19 -0500, Kautuk Consul wrote:
> > Also, if they're static and there's only a single callsite, gcc will
> > already inline them, does this patch really make a difference?
>
> I just sent this patch for what I thought was "correctness", but I guess
> we can let this be if you are absolutely sure that all GCC cross compilers
> for all platforms will guarantee inlining.

Typically we don't explicitly inline such large functions, unless we
need it for performance.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/