Re: [Resend 2x] thermal: Prevent polling from happening duringsystem suspend

[Pavel Machek]

On Sun 2011-11-06 14:21:38, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@xxxxxxx>
> 
> The thermal driver should use a freezable workqueue to schedule
> polling to prevent thermal_zone_device_update() from being run
> during system suspend, when the devices it relies on may be inactive.
> Make it use the system freezable workqueue for this purpose.

Umm. hibernation can take long time and (with latest compression
patches) can be CPU intensive.

Is it good idea to disable thermal management?

Should we kick fans to full speed before starting hibernation?
								Pavel

> @@ -678,10 +678,10 @@ static void thermal_zone_device_set_poll
>  		return;
>  
>  	if (delay > 1000)
> -		schedule_delayed_work(&(tz->poll_queue),
> +		queue_delayed_work(system_freezable_wq, &(tz->poll_queue),
>  				      round_jiffies(msecs_to_jiffies(delay)));
>  	else
> -		schedule_delayed_work(&(tz->poll_queue),
> +		queue_delayed_work(system_freezable_wq, &(tz->poll_queue),
>  				      msecs_to_jiffies(delay));
>  }

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/