Re: [PATCH v2 07/10] cisco/enic: use eth_hw_addr_random() insteadof random_ether_addr()

From: David Miller
Date: Fri Feb 17 2012 - 16:01:54 EST


From: Danny Kukawka <danny.kukawka@xxxxxxxxx>
Date: Fri, 17 Feb 2012 16:43:28 +0100

> Use dev_hw_addr_random() instead of calling random_ether_addr()
> to set addr_assign_type correctly to NET_ADDR_RANDOM.
>
> Couldn't replace random_ether_addr() in enic_probe() since
> enic_set_mac_addr() is used which would reset addr_assign_type.
> Instead set addr_assign_type directly to NET_ADDR_RANDOM in
> case of random mac after call enic_set_mac_addr().
>
> Reset the state to NET_ADDR_PERM as soon as the MAC get
> changed via .ndo_set_mac_address.
>
> v2: use bitops, adapt to eth_hw_addr_random(), add a comment
>
> Signed-off-by: Danny Kukawka <danny.kukawka@xxxxxxxxx>

This patch doesn't apply at all to the current net-next tree,
please always validate that your patches actually apply to the
tree before submission.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/