Re: [PATCH v2 2/2] adi: adapt to eth_hw_addr_random() and changes in arch/blackfin

[Mike Frysinger]

On Friday 17 February 2012 05:57:54 Danny Kukawka wrote:
> On Freitag, 17. Februar 2012, Mike Frysinger wrote:
> > On Thu, Feb 16, 2012 at 12:09, Danny Kukawka wrote:
> > > +                       netdev_warn(ndev, "Setting Ethernet MAC to a
> > > random one\n"); +                       eth_hw_addr_random(ndev);
> > 
> > would it make sense to have the core dump the warning ?
> 
> Maybe. Many drivers already print information about setting a random mac
> address to a netdevice. Some with printk, some via
> netdev_warn/netdev_info/netdev_dbg or netif_dbg and other with costum
> methods. I could unify this, in a next step with a netdev_info in
> eth_hw_addr_random(), if it's okay for David.

i think unification in the core makes sense.  it enforces consistency and 
removes duplication.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.